Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the ETH_800GBASE_DR8 and ETH_800GBASE_2xFR4 Ethernet PMD types to the openconfig-transport-types YANG module. Feedback was provided to include specification references for both new identities and to capitalize the 'x' in ETH_800GBASE_2xFR4 to ensure naming consistency with existing definitions in the file.
| identity ETH_800GBASE_DR8 { | ||
| base ETHERNET_PMD_TYPE; | ||
| description "Ethernet compliance code: 800GBASE_DR8"; | ||
| } |
There was a problem hiding this comment.
It is recommended to include a reference to the relevant IEEE standard (e.g., IEEE 802.3df) for this PMD type, consistent with other entries in this module.
| identity ETH_800GBASE_DR8 { | |
| base ETHERNET_PMD_TYPE; | |
| description "Ethernet compliance code: 800GBASE_DR8"; | |
| } | |
| identity ETH_800GBASE_DR8 { | |
| base ETHERNET_PMD_TYPE; | |
| description "Ethernet compliance code: 800GBASE_DR8"; | |
| reference "IEEE 802.3df"; | |
| } |
| identity ETH_800GBASE_2xFR4 { | ||
| base ETHERNET_PMD_TYPE; | ||
| description "Ethernet compliance code: 800GBASE_2xFR4"; | ||
| } |
There was a problem hiding this comment.
For consistency with existing multiplier-based identities in this module (such as ETH_4X10GBASE_LR on line 1199), the 'x' in the identity name should be uppercase. Additionally, adding a reference to the relevant specification (e.g., 800G Pluggable MSA) would improve maintainability.
| identity ETH_800GBASE_2xFR4 { | |
| base ETHERNET_PMD_TYPE; | |
| description "Ethernet compliance code: 800GBASE_2xFR4"; | |
| } | |
| identity ETH_800GBASE_2XFR4 { | |
| base ETHERNET_PMD_TYPE; | |
| description "Ethernet compliance code: 800GBASE_2xFR4"; | |
| reference "800G Pluggable MSA"; | |
| } |
|
No major YANG version changes in commit cb9b217 |
|
openconfig-transport-types.yang: file updated but openconfig-version string not updated: "1.3.0" |
3 participants
[Note: Please fill out the following template for your pull request. Replace
all the text in
[]with your own content.][Note: Before this PR can be reviewed please agree to the CLA covering this
repo. Please also review the contribution guide -
https://github.com/openconfig/public/blob/master/doc/contributions-guide.md]
Change Scope
Platform Implementations
implementation output.
implementation output.
[Note: Please provide at least two references to implementations which are relevant to the model changes proposed. Each implementation should be from separate organizations.].
[Note: If the feature being proposed is new - and something that is being
proposed as an enhancement to device functionality, it is sufficient to have
reviewers from the producers of two different implementations].
Tree View
diffformat is used for ease of review.][Next, cut and paste the relevant portion of the tree with enough context for reviewers to quickly understand the change.]
module: openconfig-interfaces +--rw interfaces +--rw interface* [name] +--ro state | +--ro counters | | +--ro in-octets? oc-yang:counter64 | | +--ro in-pkts? oc-yang:counter64 | | +--ro in-unicast-pkts? oc-yang:counter64 | | +--ro in-broadcast-pkts? oc-yang:counter64 | | +--ro in-multicast-pkts? oc-yang:counter64 | | +--ro in-errors? oc-yang:counter64 | | +--ro in-discards? oc-yang:counter64 | | +--ro out-octets? oc-yang:counter64 | | +--ro out-pkts? oc-yang:counter64 | | +--ro out-unicast-pkts? oc-yang:counter64 | | +--ro out-broadcast-pkts? oc-yang:counter64 | | +--ro out-multicast-pkts? oc-yang:counter64 | | +--ro out-discards? oc-yang:counter64 | | +--ro out-errors? oc-yang:counter64 | | +--ro last-clear? oc-types:timeticks64 | | +--ro in-unknown-protos? oc-yang:counter64 | | +--ro in-fcs-errors? oc-yang:counter64 + | | x--ro carrier-transitions? oc-yang:counter64 - | | +--ro carrier-transitions? oc-yang:counter64 + | | +--ro interface-transitions? oc-yang:counter64 + | | +--ro link-transitions? oc-yang:counter64 | | +--ro resets? oc-yang:counter64